Moves css and js to assets, enables bundling and minify #447
Conversation
✅ Deploy Preview for rladies-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Nice!
On https://deploy-preview-447--rladies-dev.netlify.app/activities/events/ I see no event but is that normal for a preview?
|
|
||
| {{ define "footer" }} | ||
| <script type="text/javascript"> | ||
| {{ $js := slice |
There was a problem hiding this comment.
this is nice! for the rOpenSci website we minified externally but this is cleaner.
| {{ $data.Set "string" "https://twitter.com/%s" }} | ||
| {{ $data.Set "fa" "fab fa-twitter" }} | ||
| {{ $data.Set "fa" "fa-brands fa-twitter" }} |
There was a problem hiding this comment.
btw should we remove twitter links
There was a problem hiding this comment.
I'm note sure. There are many of them in the directory, and while WE dont use it, I'm not sure we should not link to them if other do? I'm a little torn.
we have no events because the metup API changed and meetupr has not been updated for that :( |
2 participants
This should not have any visible effects on the website.
For efficient bundling, css and js files have been moved to
assetsfolder inside the theme