don't delete the handler in loseConnection #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you call loseConnection on the WebSocketTransport it passes it on to the underlying Request, which then errbacks the notifications obtained with notifyFinish(), and WebSocketTransport then gets connectionLost on itself... and tries to call self._handler.connectionLost(), but the handler is already deleted.
I think you don't have to delete the handler in loseConnection, because connectionLost is going to be called anyway, so you can do it there.