Skip to content

chore: Bump to Gradle 8.14.1 #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2025
Merged

chore: Bump to Gradle 8.14.1 #748

merged 4 commits into from
May 24, 2025

Conversation

rm3l
Copy link
Owner

@rm3l rm3l commented Mar 12, 2023

Summary by Sourcery

Upgrade Gradle wrapper versions and migrate the Shadow plugin configuration across crawler modules.

Enhancements:

  • Replace deprecated com.github.johnrengelman.shadow plugin with com.gradleup.shadow and update shadowJar task configuration in crawler projects.

Build:

  • Bump backend Gradle wrapper to 8.14.1.
  • Bump Android Gradle wrapper to 7.6.1.

@rm3l rm3l changed the title Bump to Gradle 8.0.2 chore: Bump to Gradle 8.0.2 Mar 12, 2023
@rm3l rm3l added the dependencies Pull requests that update a dependency file label Mar 12, 2023
@rm3l rm3l force-pushed the bump_gradle_8.0.2 branch from 1c2c532 to d074bb3 Compare May 24, 2025 14:38
@rm3l rm3l changed the title chore: Bump to Gradle 8.0.2 chore: Bump to Gradle 8.14.1 May 24, 2025
@rm3l rm3l marked this pull request as ready for review May 24, 2025 14:54
@rm3l rm3l merged commit ebb6387 into master May 24, 2025
6 checks passed
@rm3l rm3l deleted the bump_gradle_8.0.2 branch May 24, 2025 14:55
Copy link

sourcery-ai bot commented May 24, 2025

Reviewer's Guide

This PR updates the Gradle wrapper versions for both backend and mobile modules and migrates the Shadow plugin in all crawler projects to the new com.gradleup.shadow plugin with its updated DSL.

File-Level Changes

Change Details Files
Migrate Shadow plugin to new com.gradleup.shadow version and update its task DSL
  • Replace plugin id and version from com.github.johnrengelman.shadow 7.1.2 to com.gradleup.shadow 8.3.6
  • Convert shadowJar block to tasks.named('shadowJar') with archiveClassifier property
backend/crawlers/discoverdev.io/build.gradle
backend/crawlers/engineeringblogs.xyz/build.gradle
backend/crawlers/rm3l.org/build.gradle
Bump backend Gradle wrapper to 8.14.1
  • Update distributionUrl to gradle-8.14.1-bin.zip
backend/gradle/wrapper/gradle-wrapper.properties
Bump mobile Android Gradle wrapper to 7.6.1
  • Update distributionUrl to gradle-7.6.1-bin.zip
mobile/android/gradle/wrapper/gradle-wrapper.properties

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rm3l - I've reviewed your changes - here's some feedback:

  • Consider centralizing the shadow plugin version and shadowJar configuration in a shared Gradle configuration (e.g. in the root build script) to avoid duplicating it across all crawler modules.
  • The mobile/android wrapper was bumped only to Gradle 7.6.1—if you intend to standardize on Gradle 8.14.1, update the Android wrapper to match or confirm the version skew is intentional.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant