-
Notifications
You must be signed in to change notification settings - Fork 11
chore: Bump to Gradle 8.14.1 #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This seems to be what Flutter supports so far https://docs.flutter.dev/release/breaking-changes/android-java-gradle-migration-guide#solution-2-manual-fix-at-the-command-line
Reviewer's GuideThis PR updates the Gradle wrapper versions for both backend and mobile modules and migrates the Shadow plugin in all crawler projects to the new com.gradleup.shadow plugin with its updated DSL. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rm3l - I've reviewed your changes - here's some feedback:
- Consider centralizing the shadow plugin version and shadowJar configuration in a shared Gradle configuration (e.g. in the root build script) to avoid duplicating it across all crawler modules.
- The mobile/android wrapper was bumped only to Gradle 7.6.1—if you intend to standardize on Gradle 8.14.1, update the Android wrapper to match or confirm the version skew is intentional.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Upgrade Gradle wrapper versions and migrate the Shadow plugin configuration across crawler modules.
Enhancements:
Build: