Message Archive Management handling remote messages by inferring direction instead. Adds MAM 2 support.#1229
Open
Teglgaard wants to merge 13 commits intorobbiehanson:masterfrom
Open
Message Archive Management handling remote messages by inferring direction instead. Adds MAM 2 support.#1229Teglgaard wants to merge 13 commits intorobbiehanson:masterfrom
Teglgaard wants to merge 13 commits intorobbiehanson:masterfrom
Conversation
…e they would always be incoming.
…er instead so it can be used for MAM XEP-0313
…st commit it seemed that everything was working as inteded but we had a parameter which were not longer used. (If you want to see the only changes needed please see last commit.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using MAM 2 but would not be able to process the messages since all incoming messages are tagged with isOutgoing = false even though the message originally came from ourself.
To solve that issue we instead infer the direction.
By using above we then process the necessary answer below:
By doing above combined with the code allows the messages to be stored correctly.
We discussed a couple of developers if they could find use cases for setting the direction manually and we could not.