Use just as the task runner instead of make - #1466
Merged
Merged
Conversation
Port the root Makefile to just (https://github.com/casey/just). In this project `make` was used as a task runner rather than a build tool, and just is more straightforward for this. - The `PACKAGE` variable used by the WASM test and benchmark targets becomes a recipe parameter, so `make wasm-test PACKAGE=rten-simd` is now `just wasm-test rten-simd`. `RELAXED=y` becomes a just variable, set as `just relaxed=y wasm-test`. - just has no equivalent of make's file-based dependencies, so `just schema` regenerates the FlatBuffers bindings unconditionally. - The WASM test and benchmark recipes deleted stale test binaries from `target/wasm32-wasi/`, but the builds write to `target/wasm32-wasip1/`, so nothing was ever removed. The recipes now use the path the build uses. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the root Makefile to just (https://github.com/casey/just). In this project
makewas used as a task runner rather than a build tool, and just is more straightforward for this.The
PACKAGEvariable used by the WASM test and benchmark targets becomes a recipe parameter, somake wasm-test PACKAGE=rten-simdis nowjust wasm-test rten-simd.RELAXED=ybecomes a just variable, set asjust relaxed=y wasm-test.just has no equivalent of make's file-based dependencies, so
just schemaregenerates the FlatBuffers bindings unconditionally.The WASM test and benchmark recipes deleted stale test binaries from
target/wasm32-wasi/, but the builds write totarget/wasm32-wasip1/, so nothing was ever removed. The recipes now use the path the build uses.