Skip to content

Optimize recursive deletes in S3. #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teo-tsirpanis wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −2
Open

Optimize recursive deletes in S3. #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions FluentStorage.AWS/Blobs/AwsS3DirectoryBrowser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ private async Task ListFolderAsync(List<Blob> container, string path, ListOption
Delimiter = options.Recurse ? null : "/" //this tells S3 not to go into the folder recursively
};

// Server side filtering is supported by supplying a FilePrefix
// Server side filtering is supported by supplying a FilePrefix
if (!string.IsNullOrEmpty(options.FilePrefix)) {
request.Prefix += options.FilePrefix;
}
Expand Down Expand Up @@ -103,7 +103,10 @@ public async Task DeleteRecursiveAsync(string fullPath, CancellationToken cancel
if (response?.S3Objects == null)
break;

await Task.WhenAll(response.S3Objects.Select(s3 => _client.DeleteObjectAsync(_bucketName, s3.Key, cancellationToken))).ConfigureAwait(false);
await _client.DeleteObjectsAsync(new DeleteObjectsRequest() {
BucketName = _bucketName,
Objects = response.S3Objects.Select(s3 => new KeyVersion() { Key = s3.Key }).ToList()
}, cancellationToken).ConfigureAwait(false);

if (response.NextContinuationToken == null)
break;
Expand Down