Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline termination when processing is over #1095

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

PawelPeczek-Roboflow
Copy link
Collaborator

@PawelPeczek-Roboflow PawelPeczek-Roboflow commented Mar 21, 2025

Description

We had a bug in batch processing leading processes to hang in a situation when there is error in inference thread - then Inference pipeline shuts down all of the internal threads apart from video sources - which are closed only when .terminate(...) is called.

This solution is just bug-fix - in new iteration of InferencePipeline we need to design it better to handle such cases.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

  • e2e test against problematic workflow

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit 581d7d1 into main Mar 21, 2025
30 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the fix/kill-video-processing-on-error branch March 21, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants