Toucan offseason changes #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 53d2599. The commit was a temporary change, and we have new wheels now
KangarooKoala
dismissed
RobototesProgrammers’s stale review
This was only for testing whether any programmer's approval would suffice
markpete
reviewed
Jan 25, 2025
| "conversionFactor": { | ||
| "angle": 19.2, | ||
| "drive": 0.0696793458626792 | ||
| "drive": 0.06658958893604663608562691131498 |
There was a problem hiding this comment.
Floats only have 7 significant digits (plus an exponent) and doubles have 16 decimal digits (plus an exponent) of precision, so this may be overkill.
https://en.wikipedia.org/wiki/Floating-point_arithmetic#IEEE_754:_floating_point_in_modern_computers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Toucan code at offseason events