Update to less functors #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of storing functions in the server and client state
reynir
approved these changes
Feb 11, 2025
| @@ -625,7 +619,7 @@ let incoming_control_client config rng session channel now op data = | |||
| ca); | |||
| X509.Authenticator.chain_of_trust | |||
| (* ~allowed_hashes:Mirage_crypto.Hash.hashes *) | |||
| ~time:(fun () -> Some now) | |||
| ~time:(fun () -> Some (Mirage_ptime.now ())) | |||
There was a problem hiding this comment.
Now we call Mirage_ptime.now () at a later point. I think that's ok.
There was a problem hiding this comment.
Actually, did we have a bug here? Using the same timestamp always doesn't seem right. If the handshake takes sufficiently long I guess we could accept a certificate that just expired (small window of whatever timeout we have). I don't remember the protocol in full, but I don't think we would handshake again with this same authenticator.
| @@ -884,7 +878,7 @@ let incoming_control_server auth_user_pass is_not_taken config rng session | |||
| Ok | |||
| (Some | |||
| (X509.Authenticator.chain_of_trust | |||
| ~time:(fun () -> Some now) | |||
| ~time:(fun () -> Some (Mirage_ptime.now ())) | |||
| @@ -896,7 +890,7 @@ let incoming_control_server auth_user_pass is_not_taken config rng session | |||
| | Ok _ -> acc | |||
| | Error _ -> | |||
| X509.Validation.trust_cert_fingerprint | |||
| ~time:(fun () -> Some now) | |||
| ~time:(fun () -> Some (Mirage_ptime.now ())) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this updates this package with recent changes (in flight) of mirageos packages. this will need to wait until the dns release is merged (ocaml/opam-repository#27408), and then also the unikernels will need to be updated (which will require a mirage release)