Improve external type handling #8316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XPECTED section for /Users/runner/work/roc/roc/test/snapshots/type_comprehensive_scope.md
Expected:
TYPE REDECLARED - type_comprehensive_scope.md:10:1:10:37
UNDECLARED TYPE - type_comprehensive_scope.md:13:19:13:23
COMPILER DIAGNOSTIC - /Users/rtfeldman/code/roc/test/snapshots/type_comprehensive_scope.md:0:0:0:0
UNDECLARED TYPE - type_comprehensive_scope.md:25:11:25:29
UNDECLARED TYPE - type_comprehensive_scope.md:29:10:29:14
Generated:
TYPE REDECLARED - type_comprehensive_scope.md:10:1:10:37
UNDECLARED TYPE - type_comprehensive_scope.md:13:19:13:23
COMPILER DIAGNOSTIC - /Users/runner/work/roc/roc/test/snapshots/type_comprehensive_scope.md:0:0:0:0
UNDECLARED TYPE - type_comprehensive_scope.md:25:11:25:29
UNDECLARED TYPE - type_comprehensive_scope.md:29:10:29:14
Hint: use `zig build snapshot -- --update-expected` to automatically update the expectations.
Mismatch in EXPECTED section for /Users/runner/work/roc/roc/test/snapshots/type_scope_integration.md
Expected:
COMPILER DIAGNOSTIC - /Users/rtfeldman/code/roc/test/snapshots/type_scope_integration.md:0:0:0:0
UNDECLARED TYPE - type_scope_integration.md:8:7:8:25
Generated:
COMPILER DIAGNOSTIC - /Users/runner/work/roc/roc/test/snapshots/type_scope_integration.md:0:0:0:0
UNDECLARED TYPE - type_scope_integration.md:8:7:8:25
Hint: use `zig build snapshot -- --update-expected` to automatically update the expectations.
Mismatch in EXPECTED section for /Users/runner/work/roc/roc/test/snapshots/type_redeclaration_same_scope.md
Expected:
COMPILER DIAGNOSTIC - /Users/rtfeldman/code/roc/test/snapshots/type_redeclaration_same_scope.md:0:0:0:0
Generated:
COMPILER DIAGNOSTIC - /Users/runner/work/roc/roc/test/snapshots/type_redeclaration_same_scope.md:0:0:0:0
Hint: use `zig build snapshot -- --update-expected` to automatically update the expectations.
/Users/runner/work/roc/roc/src/snapshot_tool/main.zig:3013:9: 0x10c68a4b2 in test.snapshot validation (snapshot_tool_test)
return error.SnapshotValidationFailed;
^
error: while executing test 'main.Meta.test.Meta.fromString - desc and invalid type', the following test command failed:
/Users/runner/.cache/zig/o/689e2141bd9a647898a7809c8e56ee0a/snapshot_tool_test --cache-dir=/Users/runner/.cache/zig --seed=0x9cd082e1 --listen=-
Build Summary: 47/50 steps succeeded; 1 failed; 1173/1235 tests passed; 61 skipped; 1 failed
test transitive failure
+- tests_summary transitive failure
+- run test snapshot_tool_test 6/15 passed, 1 failed, 8 skipped
error: the following build command failed with exit code 1:
/Users/runner/.cache/zig/o/7129ac6c5516fc14589cfa1f75432137/build /Users/runner/work/_temp/0e4e92ab-6822-4b3a-a335-a1b7520680e0/zig-x86_64-macos-0.15.2/zig /Users/runner/work/_temp/0e4e92ab-6822-4b3a-a335-a1b7520680e0/zig-x86_64-macos-0.15.2/lib /Users/runner/work/roc/roc /Users/runner/.cache/zig /Users/runner/.cache/zig --seed 0x9cd082e1 -Z9d99ed2ba28f6aea test -Dfuzz -Dsystem-afl=false
Command failed with exit code 1 but error output does not contain 'double roundtrip bundle'
Not retrying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.