Skip to content

Fix uncached tables requests #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 2 commits into from
May 29, 2026
Merged

Fix uncached tables requests #1812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6862cf1
feat(connections): hide schema edit button for non-SQL databases
lyubov-voloshko May 29, 2026
37c82a4
fix(schema-viewer): stop wheel propagation on tables sidebar
lyubov-voloshko May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/app/components/connections-list/own-connections/own-connections.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ <h2 class="connectionInfo__connectionTitle">{{ $any(connectionItem).displayTitle
<span class="mat-body-2">{{ supportedDatabasesTitles[connectionItem.connection.type] }}</span>
</div>
</div>
@if (connectionItem.accessLevel === 'edit') {
@if (connectionItem.accessLevel === 'edit' && supportsSchemaEditing(connectionItem.connection.type)) {
<a mat-button color="accent"
class="connectionSchemaButton"
routerLink="/edit-database-schema/{{connectionItem.connection.id}}"
Expand Down
13 changes: 12 additions & 1 deletion frontend/src/app/components/connections-list/own-connections/own-connections.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { firstValueFrom } from 'rxjs';
import { supportedDatabasesTitles, supportedOrderedDatabases } from 'src/app/consts/databases';
import { AlertActionType, AlertType } from 'src/app/models/alert';
import { CompanyMember, CompanyMemberRole } from 'src/app/models/company';
import { ConnectionItem } from 'src/app/models/connection';
import { ConnectionItem, DBtype } from 'src/app/models/connection';
import { UiSettings } from 'src/app/models/ui-settings';
import { SubscriptionPlans, User } from 'src/app/models/user';
import { CompanyService } from 'src/app/services/company.service';
Expand Down Expand Up @@ -114,6 +114,17 @@ export class OwnConnectionsComponent implements OnInit, OnChanges {
this._uiSettings.updateGlobalSetting('connectionsListCollapsed', true);
}

supportsSchemaEditing(type: DBtype | string): boolean {
return (
type === DBtype.Postgres ||
type === DBtype.MySQL ||
type === DBtype.Oracle ||
type === DBtype.MSSQL ||
type === DBtype.DB2 ||
type === DBtype.ClickHouse
);
}

getMainTitle(database: string): string {
const title = this.supportedDatabasesTitles[database] || database;
const match = title.match(/^([^(]+)/);
Expand Down
2 changes: 1 addition & 1 deletion ...omponents/edit-database-schema/schema-diagram-viewer/schema-diagram-viewer.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ <h3 class="schema-diagram__title">{{ title }}</h3>
</div>

@if (sidebarOpen()) {
<aside class="schema-diagram__sidebar">
<aside class="schema-diagram__sidebar" (wheel)="$event.stopPropagation()">
<div class="schema-diagram__sidebar-search">
<mat-icon class="schema-diagram__sidebar-search-icon">search</mat-icon>
<input type="text" placeholder="Search tables"
Expand Down
Loading