Add support for character encoding configuration (Fixes #46)#47
Closed
renanwilliam wants to merge 1 commit intorodhoward:masterfrom
Closed
Add support for character encoding configuration (Fixes #46)#47renanwilliam wants to merge 1 commit intorodhoward:masterfrom
renanwilliam wants to merge 1 commit intorodhoward:masterfrom
Conversation
Fixes issue with special characters (accents, cedillas) when connecting
to databases using legacy encodings like Windows-1252.
Changes:
- Add optional javaEncoding parameter to SybaseDB constructor
- Pass -Dfile.encoding to Java process when javaEncoding is specified
- Update Java classes to accept encoding parameter with full backward compatibility
- Add comprehensive Mocha/Chai tests for encoding functionality
- Update documentation with encoding usage examples
The new API allows separate control of Node.js IPC encoding and Java
database encoding, resolving character encoding mismatches while
maintaining 100% backward compatibility.
Usage:
new Sybase(host, port, db, user, pass, false, null, {
encoding: 'latin1', // Node.js IPC encoding
javaEncoding: 'Cp1252' // Java database encoding
});
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Since there was no interest, I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem Solved
Resolves issue #46 where special characters are not handled correctly due to encoding mismatches between Java and Node.js components.
Changes Made
Core Implementation
javaEncodingparameter to constructor options-Dfile.encodingJVM parameter whenjavaEncodingis specifiedTesting & Documentation
New API Usage
Common Use Cases
encoding: 'latin1', javaEncoding: 'Cp1252'encoding: 'latin1', javaEncoding: 'ISO-8859-1'Backward Compatibility
✅ All existing code continues to work without changes
✅ New parameters are optional
✅ Java constructors use method overloading (no breaking changes)
✅ Default behavior unchanged
Test Results
🤖 Generated with Claude Code