Avoid re-reading the staged file when resolving its sourcemap path during breakpoint injection - #392
Open
TwitchBronBron wants to merge 1 commit into
Open
Conversation
…ring breakpoint injection writeBreakpointsToFile reads the staged file into `fileContents`, then (for source-mapped files) called getSourceMapPath, which read the exact same file again from disk just to extract its sourceMappingURL comment. - getSourceMapPath now accepts optional pre-loaded fileContents and uses them instead of reading the file when provided (still reads itself when omitted; still cached). - writeBreakpointsToFile passes the fileContents it already has, eliminating the second read. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeBreakpointsToFilereads the staged file intofileContents, then — for source-mapped files — callsgetSourceMapPath, which read the exact same file again from disk just to extract itssourceMappingURLcomment.getSourceMapPathnow accepts optional pre-loadedfileContentsand uses them instead of reading the file when provided (still reads the file itself when omitted; result is still cached).writeBreakpointsToFilepasses thefileContentsit already loaded, eliminating the second read.Telnet sessions with source maps only; small win, but it's a redundant read of a file already in memory.