chore: Simplify create-vsix inputs and improve branch resolution - #401
Merged
Conversation
Pass a single pr URL to the vscode-brightscript-language create-vsix workflow instead of separate branch/pr/repo inputs. A bare PR number dispatch input is resolved to this repo's PR URL first. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
TwitchBronBron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Passes a single
prURL to the vscode-brightscript-language create-vsix workflow instead of the separatebranch/pr/repoinputs. A bare PR number dispatch input is resolved to this repo's PR URL first.Why
That workflow now looks up the PR itself and resolves each project's build source with this priority (see rokucommunity/vscode-brightscript-language#867):
Rollout
workflow_dispatchrejects unknown inputs, so the oldbranch/repopayload fails once that PR merges (and this new payload fails until it does).🤖 Generated with Claude Code