Skip to content

Fix Roo::Base#each raising ArgumentError on empty sheets #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geremiasanti wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Roo::Base#each raising ArgumentError on empty sheets #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/roo/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ def each_with_pagename

def each(options = {})
return to_enum(:each, options) unless block_given?
return if last_row.nil?

if options.empty?
1.upto(last_row) do |line|
Expand Down
8 changes: 8 additions & 0 deletions test/roo/test_base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ def test_bug_bbu
end
end

def test_each_on_empty_sheet
with_each_spreadsheet(name: "emptysheets", format: [:openoffice, :excelx]) do |workbook|
workbook.default_sheet = workbook.sheets.first
assert_equal [], workbook.each.to_a
assert_nil workbook.first
end
end

def test_find_by_row_huge_document
skip_long_test
options = { name: "Bibelbund", format: [:openoffice, :excelx] }
Expand Down