Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
1667f07 to
8d05c5d
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Files
|
ghost
reviewed
Dec 11, 2024
| /// The hash of the batch, made by DA | ||
| pub batch_hash: H256, | ||
| /// The hash of the block, made by DA | ||
| pub block_hash: H256, |
There was a problem hiding this comment.
I used batch here, because DA only care about tx list. Not state made by present. If we call it block hash, may hint there is execution inside it? Actually, this hash contains no result of tx execution at all.
Which proposer needs is a hash which combine state and tx itself(state_root & batch_hash)
Contributor
Author
There was a problem hiding this comment.
Yes, the block hash in the proposer needs to be associated with the transaction (need to check the block based on tx hash or tx order). This is somewhat different from the batch hash in DA, but it would be best if they could be unified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POC implements rooch finality, and equip with babylon finality gadget sidecar, part of Integration babylon #2751