ci(deps): make fawltydeps audit member pyprojects + enable undeclared check - #420
ci(deps): make fawltydeps audit member pyprojects + enable undeclared check#420julietshen wants to merge 1 commit into
Conversation
fawltydeps only read the root pyproject for declared deps, so member-declared runtime deps (flask-cors on osprey_worker, aiodns/pycares on osprey_async_worker) were falsely reported as undeclared. Add the member pyprojects to its `deps`, and ignore the first-party/typing-only imports that remained (example_plugins' flat `udfs`/`async_sinks`/`register_async_plugins`, and `_typeshed`). With those false positives gone, run the full fawltydeps check (unused + undeclared) in CI instead of unused only, so imports that aren't declared can't silently rely on a transitive being present. Refs #157. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TEcfpqhza3dPepZUVWw36X
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Refs #157.
Problem
fawltydeps was configured with
deps = ["pyproject.toml"]— the root manifest only. Workspace members declare their own runtime deps, so member-declared packages were falsely reported as undeclared:flask-cors— declared inosprey_worker/pyproject.toml, imported byui_api/osprey/app.pyaiodns/pycares— declared inosprey_async_worker/pyproject.toml, imported by the async MX-lookup UDFThey were never actually missing; fawltydeps just wasn't looking at the member manifests.
Change
deps, so it audits the full declared set.ignore_undeclaredthe remaining false positives: example_plugins' flat-layout first-party modules (udfs,async_sinks,register_async_plugins) and the typing-only_typeshed.fawltydepscheck (unused and undeclared) instead of unused-only, so a future import that isn't declared can't silently depend on a transitive being present.Verified
uv tool run fawltydeps→ "No undeclared or unused dependencies detected" (exit 0), and still exits non-zero on a seeded failure.🤖 Generated with Claude Code