Skip to content

ci(deps): make fawltydeps audit member pyprojects + enable undeclared check - #420

Open
julietshen wants to merge 1 commit into
mainfrom
julietshen/fawltydeps-member-pyprojects
Open

ci(deps): make fawltydeps audit member pyprojects + enable undeclared check#420
julietshen wants to merge 1 commit into
mainfrom
julietshen/fawltydeps-member-pyprojects

Conversation

@julietshen

Copy link
Copy Markdown
Member

Refs #157.

Problem

fawltydeps was configured with deps = ["pyproject.toml"] — the root manifest only. Workspace members declare their own runtime deps, so member-declared packages were falsely reported as undeclared:

  • flask-cors — declared in osprey_worker/pyproject.toml, imported by ui_api/osprey/app.py
  • aiodns / pycares — declared in osprey_async_worker/pyproject.toml, imported by the async MX-lookup UDF

They were never actually missing; fawltydeps just wasn't looking at the member manifests.

Change

  • Add the member pyprojects to fawltydeps' deps, so it audits the full declared set.
  • ignore_undeclared the remaining false positives: example_plugins' flat-layout first-party modules (udfs, async_sinks, register_async_plugins) and the typing-only _typeshed.
  • CI now runs the full fawltydeps check (unused and undeclared) instead of unused-only, so a future import that isn't declared can't silently depend on a transitive being present.

Verified

uv tool run fawltydeps → "No undeclared or unused dependencies detected" (exit 0), and still exits non-zero on a seeded failure.

🤖 Generated with Claude Code

fawltydeps only read the root pyproject for declared deps, so member-declared
runtime deps (flask-cors on osprey_worker, aiodns/pycares on osprey_async_worker)
were falsely reported as undeclared. Add the member pyprojects to its `deps`, and
ignore the first-party/typing-only imports that remained (example_plugins' flat
`udfs`/`async_sinks`/`register_async_plugins`, and `_typeshed`).

With those false positives gone, run the full fawltydeps check (unused +
undeclared) in CI instead of unused only, so imports that aren't declared can't
silently rely on a transitive being present.

Refs #157.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TEcfpqhza3dPepZUVWw36X
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@julietshen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c9728450-51c9-4549-bd41-28eefd15dc75

📥 Commits

Reviewing files that changed from the base of the PR and between 5ab1d79 and da86b66.

📒 Files selected for processing (2)
  • .github/workflows/code-quality.yml
  • pyproject.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julietshen/fawltydeps-member-pyprojects

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant