feat(ui-api): Ask SSE blueprint factory - #427
Draft
haileyok wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add osprey_worker/ui_api/lib/ask: format_sse (versioned SSE framing that raises SerializationError on a non-serializable payload) and create_ask_blueprint -- a host-configurable Flask factory that validates the JSON body (strict Pydantic v1), derives the principal from a host-supplied provider (never the body), drives AskService.run_turn behind a safe pre-flight boundary (unexpected host-adapter failures become a safe JSON 500), and streams events with a terminal-seen guard so a started stream always ends in exactly one done/error. Not registered in create_app(); exercised via a dedicated test app. Also widen AskService.run_turn's return annotation to Generator so the transport can close() it for prompt lock release. Tests (16 passing under run-tests.sh) cover content-type/framing/versioning, malformed/ wrong-type/missing-provider/ownership/model/lock pre-flight errors, throwing factory/ principal safe 500s, safe provider-failure error frames, serialization-failure termination, and the terminal guard. Implements osprey-ask-ai AC4.1-AC4.5.
haileyok
force-pushed
the
hailey/ask-ai-2-service
branch
from
July 14, 2026 22:13
45f307d to
44cfeca
Compare
haileyok
force-pushed
the
hailey/ask-ai-3-sse
branch
from
July 14, 2026 22:13
f198727 to
1773779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 3/5 of the Ask AI stack (stacked on
hailey/ask-ai-2-service). Addsosprey_worker/ui_api/lib/ask: versioned SSE serialization andcreate_ask_blueprint(...)— a host-configurable Flask factory that validates the JSON body (strict Pydantic v1), derives the principal from a host-supplied provider (never the body), drivesAskService.run_turnbehind a safe pre-flight boundary (unexpected host-adapter failures become a safe JSON 500), and streams events with a terminal-seen guard so a started stream always ends in exactly one done/error. Not registered increate_app(); exercised via a dedicated test app. Implements AC4.1–AC4.5.Checklist
./run-tests.sh)uv run ruff check .passesuv tool run fawltydeps --check-unused --pyenv .venvpassesCHANGELOG.md(deferred — happy to add)