feat(ask-ai): generic Ask AI frontend client + store - #428
Draft
haileyok wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add osprey_ui/src/components/ask_ai: typed wire+domain contracts, a chunk-safe POST-SSE client (fetch + ReadableStream reader + TextDecoder) that tolerates split frames, stops at the terminal, rejects unknown event types, maps pre-flight HTTP errors to a safe AskStreamError, and always cancels the reader; plus createAskStore (Zustand v3, injectable stream) with a monotonic requestId stale-guard, AbortController cancellation, retry/ new-chat/reset, and safe error mapping that never leaks a raw stack. Tests (16 passing: pnpm typecheck + eslint + rstest) cover frame splitting/no-loss, malformed/unknown-type rejection, missing-terminal, reader cancellation, happy-path apply, stale-response guard, abort, error mapping, retry de-dup, and new-chat. Implements osprey-ask-ai AC5.1, AC5.3, and the state parts of AC5.4.
haileyok
force-pushed
the
hailey/ask-ai-4-frontend
branch
from
July 14, 2026 22:13
cad34a7 to
ea6844e
Compare
haileyok
force-pushed
the
hailey/ask-ai-3-sse
branch
from
July 14, 2026 22:13
f198727 to
1773779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 4/5 of the Ask AI stack (stacked on
hailey/ask-ai-3-sse; shares only the JSON wire contract with the backend). Addsosprey_ui/src/components/ask_ai: typed wire+domain contracts, a chunk-safe POST-SSE client (fetch+ReadableStreamreader +TextDecoder) that tolerates split frames, stops at the terminal, rejects unknown event types, maps pre-flight HTTP errors to a safe error, and always cancels the reader; plus a Zustand store (createAskStore) with a monotonic stale-request guard, abort handling, retry/new-chat/reset, and safe error mapping. Implements AC5.1, AC5.3, and the state parts of AC5.4.Checklist
pnpm typecheck+eslint+rstest)uv run ruff check .passes (n/a to UI, backend unchanged)uv tool run fawltydeps --check-unused --pyenv .venvpassesCHANGELOG.md(deferred — happy to add)