[6.36][geom] Fix vecgeom interface #18508
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of the function ComputeNormal has changed in the base class TGeoBBox. Add const qualifier to the function also in the derrived class,
|
Thanks for this PR! could you please propose it for master so that we can organise a backport once approved? |
|
How do I propose it for master? Should I create another PR to the master branch? |
This comment was marked as outdated.
This comment was marked as outdated.
ferdymercury
changed the title
ferdymercury
requested review from
bellenot,
pcanal,
couet and
dpiparo
as code owners
|
EDIT: Sorry, yes, please, create another PR to the master branch to avoid merge conflicts. |
ferdymercury
changed the title
Test Results 18 files 18 suites 3d 20h 36m 30s ⏱️ Results for commit 05db8e1. |
Yes please. Then once that is approved and runs ok, we can backport it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of the function ComputeNormal has changed in the base class TGeoBBox. Add const qualifier to the function also in the derived class,
This Pull request:
Changes or fixes:
The changes fixes a compilation crash when trying to build root v-36-00-rc1 with vecgeom support.
Checklist:
This PR fixes #