Skip to content

[hist] Implement initial RProfile#22588

Merged
hahnjo merged 7 commits into
root-project:masterfrom
hahnjo:hist-profile
Jun 26, 2026
Merged

[hist] Implement initial RProfile#22588
hahnjo merged 7 commits into
root-project:masterfrom
hahnjo:hist-profile

Conversation

@hahnjo

@hahnjo hahnjo commented Jun 12, 2026

Copy link
Copy Markdown
Member

It builds on RHistEngine with an additional variable.

@hahnjo hahnjo self-assigned this Jun 12, 2026
@hahnjo hahnjo added in:Hist test coverage Run the test code coverage workflow on this PR labels Jun 12, 2026
Comment thread hist/histv7/inc/ROOT/RProfile.hxx
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 17h 37m 53s ⏱️
 3 876 tests  3 875 ✅ 0 💤 1 ❌
78 827 runs  78 826 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 1defbd5.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.23077% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.83%. Comparing base (e39fc3f) to head (311c361).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
hist/histv7/inc/ROOT/RProfile.hxx 99.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22588      +/-   ##
==========================================
+ Coverage   59.81%   59.83%   +0.02%     
==========================================
  Files        3369     3370       +1     
  Lines      495685   495978     +293     
  Branches    95189    95186       -3     
==========================================
+ Hits       296470   296754     +284     
- Misses     199215   199224       +9     
Flag Coverage Δ
unittests 59.83% <99.23%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hahnjo hahnjo marked this pull request as ready for review June 16, 2026 06:53
@hahnjo hahnjo requested review from jblomer and siliataider June 16, 2026 06:53

@jblomer jblomer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! LGTM.

Comment thread hist/histv7/inc/ROOT/RProfile.hxx
Comment thread hist/histv7/test/hist_profile.cxx
Comment thread hist/histv7/inc/ROOT/RHistEngine.hxx
Comment thread hist/histv7/inc/ROOT/RProfile.hxx
@hahnjo hahnjo removed the test coverage Run the test code coverage workflow on this PR label Jun 24, 2026
Comment thread hist/histv7/inc/ROOT/RProfile.hxx Outdated
@hahnjo hahnjo merged commit 888f7bd into root-project:master Jun 26, 2026
59 of 61 checks passed
@hahnjo hahnjo deleted the hist-profile branch June 26, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants