[HS3][RF] I/O for RooWrapperPdf and RooExtendPdf#22647
Merged
guitargeek merged 2 commits intoJun 19, 2026
Merged
Conversation
guitargeek
reviewed
Jun 17, 2026
Test Results 22 files 22 suites 3d 12h 37m 21s ⏱️ Results for commit 8e45bb6. ♻️ This comment has been updated with latest results. |
Added I/O for RooWrapperPdf and changed extendpdf I/O to be compliant with HS3.
guitargeek
force-pushed
the
roowrapperextendpdf-jsonio
branch
from
8e45bb6 to
8e50c5f
Compare
Refactor the HS3 serialization code to remove duplicated logic without any change in behavior. All hs3, histfactory and JSON tests still pass. JSONFactories_RooFitCore.cxx: - Drop RooLegacyExpPolyFactory; it was identical to the existing RooPolynomialFactory<RooLegacyExpPoly>, which is now registered directly. - Drop RooLegacyExpPolyStreamer; it was identical to RooPolynomialStreamer<RooLegacyExpPoly>. - Merge RooHistFuncStreamer/RooHistPdfStreamer into RooHistStreamer<T> and RooHistFuncFactory/RooHistPdfFactory into RooHistFactory<T>; each pair differed only by the concrete RooFit type. RooJSONFactoryWSTool.cxx: - Remove fillSeqSanitizedName, which had no callers anywhere in ROOT. - Factor the "make a valid name but refuse to change the first character" block (exportCategory, exportCombinedData) into makeValidNameOrError(). - Collapse the repeated ofstream/ifstream open-and-error boilerplate in exportJSON/exportYML/importJSON/importYML. error() is [[noreturn]], so the trailing 'return false' statements were dead code. JSONFactories_HistFactory.cxx: - Remove a redundant mid-file block of #includes (<regex> was already included; the others were already used earlier in the translation unit). JSONIO.cxx: - Deduplicate removeImporters/removeExporters and printImporters/ printExporters into shared templated helpers.
guitargeek
force-pushed
the
roowrapperextendpdf-jsonio
branch
from
9f2631c to
e91b0d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added I/O for roowrapperpdf and changed extendpdf I/O to be compliant with hs3
This Pull request:
adds JSONIO for the two classes mentioned
Changes or fixes:
Checklist:
This PR fixes #