Skip to content

[ntuple] always load streamer info on file open - #23252

Open
jblomer wants to merge 2 commits into
root-project:masterfrom
jblomer:ntuple-load-streamerinfo
Open

[ntuple] always load streamer info on file open#23252
jblomer wants to merge 2 commits into
root-project:masterfrom
jblomer:ntuple-load-streamerinfo

Conversation

@jblomer

@jblomer jblomer commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Follow-up of #23196

@jblomer
jblomer requested review from enirolf, hahnjo and pcanal September 4, 2026 06:39
@jblomer jblomer self-assigned this Sep 4, 2026
@jblomer
jblomer requested a review from silverweed as a code owner September 4, 2026 06:39
@jblomer
jblomer marked this pull request as draft September 4, 2026 06:39
@dpiparo dpiparo changed the title [ntuple] always laod streamer info on file open (WIP) [ntuple] always load streamer info on file open (WIP) Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 11h 17m 27s ⏱️
 3 870 tests  3 869 ✅ 0 💤 1 ❌
75 071 runs  75 070 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 1110602.

♻️ This comment has been updated with latest results.

@jblomer
jblomer force-pushed the ntuple-load-streamerinfo branch from 525ef83 to 01978ab Compare September 4, 2026 13:25
@jblomer jblomer changed the title [ntuple] always load streamer info on file open (WIP) [ntuple] always load streamer info on file open Sep 4, 2026
@jblomer
jblomer marked this pull request as ready for review September 4, 2026 13:25
@jblomer
jblomer force-pushed the ntuple-load-streamerinfo branch from 01978ab to 1110602 Compare September 4, 2026 13:35
Populate the streamer infos of the file on LoadStructure(). This will
make sure it is loaded together with the header and footer. We don't
load the streamer info directly on file open in order to prevent
computational work (decompressing the record) taking place when we open
the file asynchronously.
@pcanal

pcanal commented Sep 4, 2026

Copy link
Copy Markdown
Member

For the record a side effect of this change is (likely) a change of the timing of the auto loading of libraries when using RMiniFile (from "page loading" to "header and footer loading". (Side note, for TFile this is done at file opening).

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants