catch errors in check-on-cran fn

ropensci-review-tools · May 14, 2024 · 627df5e · 627df5e
1 parent 5228445
commit 627df5e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: pkgcheck
 Title: rOpenSci Package Checks
-Version: 0.1.2.029
+Version: 0.1.2.030
 Authors@R: c(
     person("Mark", "Padgham", , "[email protected]", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-2172-5265")),

diff --git a/R/check-on-cran.R b/R/check-on-cran.R
@@ -37,21 +37,22 @@ pkgchk_on_cran <- function (checks) {
             error = function (e) e
         )
 
-        if (methods::is (x, "simpleError")) {
-            res <- FALSE
-        } else {
+        res <- FALSE
+        if (!methods::is (x, "simpleError")) {
             h2 <- paste0 (rvest::html_elements (x, "h2"))
             h2 <- gsub ("<h2>|<\\/h2>", "", h2)
-            res <- grepl (desc$Title, h2, fixed = TRUE) |
-                grepl (desc$Title, h2, ignore.case = TRUE, perl = TRUE)
+            if (length (h2) > 0L) {
+                res <- grepl (desc$Title, h2, fixed = TRUE) |
+                    grepl (desc$Title, h2, ignore.case = TRUE, perl = TRUE)
 
-            if (!res) { # Title may have changed; check URL as backup
-                tab <- rvest::html_table (x) [[1]]
-                if (ncol (tab) == 2) {
-                    names (tab) <- c ("field", "value")
-                    tab <- tab [grep ("^URL", tab$field), ]
-                    url <- paste0 (tab$value, collapse = ", ")
-                    res <- identical (url, desc$URL)
+                if (!res) { # Title may have changed; check URL as backup
+                    tab <- rvest::html_table (x) [[1]]
+                    if (ncol (tab) == 2) {
+                        names (tab) <- c ("field", "value")
+                        tab <- tab [grep ("^URL", tab$field), ]
+                        url <- paste0 (tab$value, collapse = ", ")
+                        res <- identical (url, desc$URL)
+                    }
                 }
             }
         }

diff --git a/codemeta.json b/codemeta.json
@@ -8,7 +8,7 @@
   "codeRepository": "https://github.com/ropensci-review-tools/pkgcheck",
   "issueTracker": "https://github.com/ropensci-review-tools/pkgcheck/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.1.2.029",
+  "version": "0.1.2.030",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",