Skip to content

RateLimiter: Don't update parameters before input checks #437

@christophfroehlich

Description

@christophfroehlich

We should change the rate_limiter class to throw the errors of the input checks before the member variables are set. So we can catch the errors in the diff_drive_controller::SpeedLimiter::set_params method, otherwise we have to reimplement the checks to avoid crashing the controller.

Originally posted by @christophfroehlich in ros-controls/ros2_controllers#1781 (comment)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions