add calibration_setup_helper program#31
Conversation
|
you need to include foolowing PRs to run examples |
9a4f0e2 to
eb1dac8
Compare
|
It may not work well, please do not merge yet |
e467b61 to
f93eac6
Compare
f93eac6 to
2fcb6f7
Compare
|
I think it is now ok to merge |
|
+1 |
calibration_setup_helper/package.xml
Outdated
There was a problem hiding this comment.
please @k-okada , set yourself as an author and maintainer.
|
also, please add a REAMD file that contains what you described at the beginning of that bug report. |
|
I didn't look at it in detail, but it seems fine. |
There was a problem hiding this comment.
please add a license (may I recommend Apache 2.0 like anything OSRF does), you can copy paste from here:https://github.com/ros-aldebaran/romeo_robot/blob/master/romeo_description/scripts/generate_urdf.py
|
please set yourself as an author/maintainer. Installing your script would be more proper with a setup.py (especially to make your code runnable from Python3) |
|
ok, I have fexed, and also create #37 that include branch to use setup.py. Just to make sure that if se use setup.py , it install the script under global bin instead of package bin. Is it ok? |
|
You are totally right, this is not ok :( I was wrong. |
add calibration_setup_helper program
use C-c to step