Individual strings uri and resource_string replaced by Resource msg
#13
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Norbert Prokopiuk <[email protected]>
adamdbrw
approved these changes
Aug 4, 2025
Signed-off-by: Norbert Prokopiuk <[email protected]>
* solve uncrustify style divergence: Code style divergence in file '/tmp/ws/build_isolated/simulation_interfaces/rosidl_generator_c/simulation_interfaces/msg/detail/world_resource__struct.h': --- /tmp/ws/build_isolated/simulation_interfaces/rosidl_generator_c/simulation_interfaces/msg/detail/world_resource__struct.h +++ /tmp/ws/build_isolated/simulation_interfaces/rosidl_generator_c/simulation_interfaces/msg/detail/world_resource__struct.h.uncrustify @@ -35 +35 @@ - * and, depending on the simulator, loaded from local or remote repositories. + * and, depending on the simulator, loaded from local or remote repositor[chore] formatting fix Signed-off-by: Mateusz Żak <[email protected]>
ayushgnv
reviewed
Aug 6, 2025
ayushgnv
requested changes
Aug 6, 2025
Member
ayushgnv
left a comment
ayushgnv
left a comment
There was a problem hiding this comment.
Thanks for the change!
Please see the previous comment.
Signed-off-by: Norbert Prokopiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.0.0 of the standard introduced message type
Resource.LoadWorld.srvuses for request the same data types as defined inResource.msgrather than usingResourcedatatype.This PR replaces
string uriandstring resource_stringwithResource. Change is made in the same manner as inSpawnEntity.srvduring release of the version 2.0.0.