fixup the demo documentation for the image_pipeline_demo #6041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
This was referenced Nov 21, 2025
Closed
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/19583728875/artifacts/4645201152. To view the resulting site:
|
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
fujitatomoya
approved these changes
Nov 21, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm.
now we can see more turtles and ROS history clearly in the screenshot 😄 love it 👍
mini-1235
approved these changes
Nov 22, 2025
Contributor
mini-1235
left a comment
mini-1235
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
ahcorde
approved these changes
Nov 24, 2025
ahcorde
added
the
backport-all
This was referenced Nov 24, 2025
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
Signed-off-by: William Woodall <[email protected]> (cherry picked from commit 3e4ac5c)
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
Signed-off-by: William Woodall <[email protected]> (cherry picked from commit 3e4ac5c)
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
Signed-off-by: William Woodall <[email protected]> (cherry picked from commit 3e4ac5c)
ahcorde
pushed a commit
that referenced
this pull request
Nov 25, 2025
(cherry picked from commit 3e4ac5c) Signed-off-by: William Woodall <[email protected]> Co-authored-by: William Woodall <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Nov 25, 2025
(cherry picked from commit 3e4ac5c) Signed-off-by: William Woodall <[email protected]> Co-authored-by: William Woodall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code for the
image_pipeline_demo(part of theintra_process_demopackage) has been wrong for a long time and the documentation was self-contradicting for some time as well. This pull request, in addition to ros2/demos#755, restores the demo to its intended behavior and cleans up the documentation here about it.I also changed our use of
intra process/interprocessto beintra-process/inter-processeverywhere, as that is more consistent and it is consistent with other sources on this topics, e.g. https://en.wikipedia.org/wiki/Inter-process_communication which usesinter-process, and our own documentation where we useintra-processcommonly.Requires ros2/demos#755
Fixes #2333
Did you use Generative AI?
No.
Additional Information
This replaces another pull request #5988, which was trying to fix this, but didn't realize the demo was actually subtly broken, not the docs.