fix: prevent char16_t redefinition on macOS #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds guards for char16_t definition to prevent conflicts with system headers. Maintains backward compatibility for all platforms.
fujitatomoya
approved these changes
Jun 2, 2025
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
this fixes a compatibility issue by ensuring that char16_t is only typedef'd in C but in C++ (where it is a built-in type). This prevents potential compilation errors when including this header in C++ code.
Signed-off-by: artcore-c <[email protected]>
ahcorde
requested changes
Oct 6, 2025
| @@ -0,0 +1,12 @@ | |||
| --- a/rosidl_dynamic_typesupport/include/rosidl_dynamic_typesupport/uchar.h | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds guards for char16_t definition to prevent conflicts with system headers. Maintains backward compatibility for all platforms.
Description
Fix Summary
Prevents
char16_tredefinition conflicts on platforms where it's already defined (notably macOS).Technical Details