Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #3

Open
wants to merge 12 commits into
base: testing
Choose a base branch
from
Open

Testing #3

wants to merge 12 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 19, 2012

Changes

Removed ImageMagik and replaced it with pure libpng code.

Issues

  • Only supports PNGs with 4 channels (RGBA) meaning it fails on some images
  • Converts 16 bit colour images to 8 bit colour when reading.

@rossy
Copy link
Owner

rossy commented May 21, 2012

This is great. I've been planning on doing this for a while. I might pull it to a separate branch though, as I still want to clean up a lot of my code before it goes in.

As for the issues, libpng's high level API should be able to automatically convert non-RGBA images to the right format. I'll take a look at this.

@ghost
Copy link
Author

ghost commented May 22, 2012

That's fair, feel free to put it into a separate branch.

@solarkennedy
Copy link

I too was looking at how to replace the IM dependency (it doesn't compile on Ubuntu Wily)
I pulled this branch and ran a comparison, the results are not the same between the old and new, and I think the old looks better. (probably due to the issues noted already in the PR) Here were my results:
https://gist.github.com/solarkennedy/2544a9fe9ff4d76bedbc

I used the same methodology as http://www.xkyle.com/a-comparison-of-image-to-ascii-conversion-tools/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants