Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix annotation t_begin/t_end clamping and improve segment display
Fix bug where clicking an annotated cell caused t_begin/t_end to be incorrectly clamped to an unrelated track's unannotated segment bounds. Root cause: validation used a stale current_annotation_index pointing to the wrong segment. Fixed by storing current_toannotate_segment directly (set to None when the selected cell is not in an unannotated segment) and using it in validation instead of index-based lookup.
Extract _get_label_segments(track_data) helper that groups consecutive same-label frames into (first_t, last_t, label) tuples, replacing a duplicate manual loop in _update_label.
Add populate_annotated_segment_range(track_id, cell_time) that uses _get_label_segments to pre-fill t_begin/t_end with the bounds of the annotated segment the clicked cell belongs to (instead of the full track range).
Update fully-annotated status line from "entire track annotated" to "entire track annotated (H, S)", showing the unique labels present on the track.