ci(goreleaser): pin project_name to shredstream-proxy#17
Merged
Conversation
So the GCS blob directory injected by Binaries-ci's goreleaser-patch
({{ .ProjectName }}/v{{ .Version }}) is always shredstream-proxy/ regardless
of build context. When build-release.yml fetches this config to rebuild an
older tag that predates the file (e.g. v0.2.12-triton-0004), goreleaser
otherwise resolves the project name to the CI repo (Binaries-ci), corrupting
the upload path.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin
project_name: shredstream-proxyin the repo's.goreleaser.yaml.Binaries-ci's
ci/goreleaser-patch.yamluploads to a GCS blob directory templated as{{ .ProjectName }}/v{{ .Version }}. In normal (default-mode) releases goreleaser auto-detects the project name asshredstream-proxy, so the path is correct. But whenbuild-release.ymlfetches this config to rebuild an older tag that predates this file (e.g.v0.2.12-triton-0004, needed by terraform#890), goreleaser resolves the project name to the CI repo (Binaries-ci) instead — uploading toBinaries-ci/...rather thanshredstream-proxy/....Pinning
project_namemakes the upload path deterministic in every build context. No effect on normal releases (it's the value already auto-detected).Test plan
v0.2.12-triton-0004viabuild-release.ymlpointing at this config; confirm it lands atgs://nomad-triton-test/shredstream-proxy/v0.2.12-triton-0004/jito-shredstream-proxy-linux-amd64.🤖 Generated with Claude Code