Skip to content

Map and Battle scenes drawing delay of official corescript ver1.6.1 #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rev2nym opened this issue Aug 23, 2018 · 1 comment
Closed

Comments

@rev2nym
Copy link
Contributor

rev2nym commented Aug 23, 2018

In official corescript ver1.6.1,
Drawing map and battle scenes is delay at scene starting.
Background image is drawn first, and tile images are drawn after it.
The cause is to begin drawing by Spriteset_Base before finishing loading image files.

It's possible to check by following way.
It's also possible to test on a Community edition corescript.

Apply this code and run as test.
It will display "false" at first calling.

var _Spriteset_Base_update =
    Spriteset_Base.prototype.update;
Spriteset_Base.prototype.update = function() {

    console.log(ImageManager.isReady());

    _Spriteset_Base_update.call(this);
};

And try following code.
This causes a stack overflow in map scene.

var _Spriteset_Base_update =
    Spriteset_Base.prototype.update;
Spriteset_Base.prototype.update = function() {

    console.log(SceneManager._scene.isReady());

    _Spriteset_Base_update.call(this);
};

These mean that sprites have begun to draw though images aren't ready.

rev2nym added a commit to rev2nym/corescript that referenced this issue Aug 23, 2018
Don't call update() before scean readies.
rev2nym added a commit to rev2nym/corescript that referenced this issue Aug 23, 2018
It's inappropriate to call the update() before scene readies.
@krmbn0576
Copy link
Collaborator

Close this because it is solved by #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants