Integrations apps by nebay-abraha · Pull Request #1016 · rspace-os/rspace-web

nebay-abraha · 2026-08-07T13:54:00Z

Description

most of the integration apps are now mocked

minor fixes

AsyncDepositorImpl.java
Avoid clearing otherProperties before merging RAID and ICSN identifiers,
which was removing properties populated from the archive configuration.
ArgosDMPProvider.java
Register Jdk8Module with a shared ObjectMapper so Optional DOI
values are serialized correctly.
gitHubTreeView.jsp
Quote the dynamic class expression so values containing spaces, such as
"directory collapsed", are treated as a single class attribute.

Testing notes

OPTIONAL

if there are any particular pre-requisites or instructions for manual testing, list them here

github-actions · 2026-08-07T13:58:16Z

Bundle Stats — Frontend bundle size change

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
549	30.67 MB 11.24 MB	0%

Changeset

File	Δ	Size
`createStyled.mjs`	🆕 +2.56 kB	0 B → 2.56 kB
`Baskets/AddToBasketDialog.tsx`	🆕 +2 kB	0 B → 2 kB
`assets/branding/rspace/other/index.ts`	🆕 +262 B	0 B → 262 B
`ReactPropTypesSecret.js`	🆕 +73 B	0 B → 73 B
`headers.js`	📈 +1.24 kB (+939.26%)	135 B → 1.37 kB
`schema.ts`	📈 +251 B (+103.29%)	243 B → 494 B
`queries.ts`	📈 +360 B (+73.02%)	493 B → 853 B
`NewField.tsx`	📈 +154 B (+35.98%)	428 B → 582 B
`CustomField.tsx`	📉 -1.7 kB (-61.71%)	2.75 kB → 1.05 kB
`createStyled/createStyled.mjs`	🔥 -2.56 kB (-100%)	2.56 kB → 0 B
`AddToBasketDialog.tsx`	🔥 -2 kB (-100%)	2 kB → 0 B
`rspace/other/index.ts`	🔥 -262 B (-100%)	262 B → 0 B
`lib/ReactPropTypesSecret.js`	🔥 -73 B (-100%)	73 B → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Copilot

Pull request overview

This PR expands the E2E integration test coverage by adding mock-backed Playwright specs and MSW handlers for many “Apps” integrations, and includes a couple of backend/JSP fixes intended to stabilize integration flows (e.g., Argos Optional DOI serialization, GitHub tree view class handling, archive submission metadata merging).

Changes:

Add Playwright E2E specs + page objects for multiple integrations (RAiD, Slack, GitHub, Nextcloud/ownCloud, protocols.io, Dryad, DMP providers, Calira, Evernote, DCD, Teams, ORCID).
Add MSW mock handlers/fixtures and wire them into the E2E mock server and dev/CI startup scripts.
Backend/JSP tweaks for integration-related serialization/markup and archive deposit metadata.

Reviewed changes

Copilot reviewed 71 out of 72 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/main/webapp/WEB-INF/pages/connect/github/gitHubTreeView.jsp	Quotes dynamic `class` attribute in GitHub tree view markup.
src/main/webapp/ui/src/modules/slack/tests/slack.e2e.ts	Adds Slack Playwright E2E spec (currently skipped for OAuth flow).
src/main/webapp/ui/src/modules/slack/tests/pageObjects/SlackDialogComponent.ts	Adds Slack dialog Playwright page object helpers.
src/main/webapp/ui/src/modules/slack/tests/mock.ts	Adds MSW handlers/constants for Slack OAuth + API mocking.
src/main/webapp/ui/src/modules/raid/tests/raid.e2e.ts	Adds RAiD Playwright E2E scenarios including export “Report to RAiD”.
src/main/webapp/ui/src/modules/raid/tests/mock.ts	Adds MSW handlers + JSON fixtures for RAiD mock API/auth.
src/main/webapp/ui/src/modules/raid/tests/fixtures/servicePoint.json	Adds RAiD service-point fixture for mock API.
src/main/webapp/ui/src/modules/raid/tests/fixtures/raids.json	Adds RAiD records fixture for mock API.
src/main/webapp/ui/src/modules/protocolsio/tests/protocolsio.e2e.ts	Adds protocols.io Playwright E2E import scenario.
src/main/webapp/ui/src/modules/protocolsio/tests/pageObjects/ProtocolsIODialogComponent.ts	Adds protocols.io dialog Playwright page object helpers.
src/main/webapp/ui/src/modules/protocolsio/tests/mock.ts	Adds MSW handlers/constants for protocols.io OAuth mocking.
src/main/webapp/ui/src/modules/owncloud/tests/pageObjects/OwnCloudDialogComponent.ts	Adds ownCloud dialog Playwright page object helpers.
src/main/webapp/ui/src/modules/owncloud/tests/owncloud.e2e.ts	Adds ownCloud Playwright E2E insert-file scenario.
src/main/webapp/ui/src/modules/owncloud/tests/mock.ts	Adds MSW handlers/constants for ownCloud OAuth + WebDAV mocking.
src/main/webapp/ui/src/modules/orcid/tests/pageObjects/OrcidProfilePage.ts	Adds ORCID profile Playwright page object helpers.
src/main/webapp/ui/src/modules/orcid/tests/orcid.e2e.ts	Adds ORCID Playwright E2E profile-connect scenario (mocked).
src/main/webapp/ui/src/modules/orcid/tests/mock.ts	Adds MSW handler/constants for ORCID token exchange mocking.
src/main/webapp/ui/src/modules/nextcloud/tests/pageObjects/NextcloudDialogComponent.ts	Adds Nextcloud dialog Playwright page object helpers.
src/main/webapp/ui/src/modules/nextcloud/tests/nextcloud.e2e.ts	Adds Nextcloud Playwright E2E insert-file scenario (real+mock branches).
src/main/webapp/ui/src/modules/nextcloud/tests/mock.ts	Adds MSW handlers/constants for Nextcloud OAuth + WebDAV mocking.
src/main/webapp/ui/src/modules/msteams/tests/pageObjects/MsTeamsShareDialogComponent.ts	Adds Teams “share” dialog Playwright component.
src/main/webapp/ui/src/modules/msteams/tests/msteams.e2e.ts	Adds Teams webhook Playwright E2E share scenario.
src/main/webapp/ui/src/modules/msteams/tests/mock.ts	Adds MSW handlers/types for capturing Teams webhook payloads.
src/main/webapp/ui/src/modules/github/tests/pageObjects/GitHubDialogComponent.ts	Adds GitHub insert dialog Playwright page object helpers.
src/main/webapp/ui/src/modules/github/tests/pageObjects/GitHubAppsCardComponent.ts	Adds GitHub Apps card Playwright page object helpers.
src/main/webapp/ui/src/modules/github/tests/mock.ts	Adds MSW handlers/constants for GitHub OAuth + API mocking.
src/main/webapp/ui/src/modules/github/tests/github.e2e.ts	Adds GitHub Playwright E2E insert-file scenario.
src/main/webapp/ui/src/modules/evernote/tests/pageObjects/EvernoteImportDialog.ts	Adds Evernote import dialog Playwright page object helpers.
src/main/webapp/ui/src/modules/evernote/tests/evernote.e2e.ts	Adds Evernote Playwright E2E import scenario using ENEX fixture.
src/main/webapp/ui/src/modules/dryad/tests/mock.ts	Adds MSW handlers for Dryad OAuth + deposit mocking.
src/main/webapp/ui/src/modules/dryad/tests/dryad.e2e.ts	Adds Dryad Playwright E2E export/deposit scenario.
src/main/webapp/ui/src/modules/dmptool/tests/pageObjects/DMPToolImportDialogComponent.ts	Adds DMPTool import dialog Playwright helpers.
src/main/webapp/ui/src/modules/dmptool/tests/mock.ts	Adds MSW handlers + fixture wiring for DMPTool plan APIs.
src/main/webapp/ui/src/modules/dmptool/tests/fixtures/plans.json	Adds DMPTool plans fixture.
src/main/webapp/ui/src/modules/dmptool/tests/dmptool.e2e.ts	Adds DMPTool Playwright E2E gallery import scenario.
src/main/webapp/ui/src/modules/dmponline/tests/pageObjects/DMPOnlineImportDialogComponent.ts	Adds DMPonline import dialog Playwright helpers.
src/main/webapp/ui/src/modules/dmponline/tests/mock.ts	Adds MSW handlers + fixture wiring for DMPonline plan APIs.
src/main/webapp/ui/src/modules/dmponline/tests/fixtures/plans.json	Adds DMPonline plans fixture.
src/main/webapp/ui/src/modules/dmponline/tests/dmponline.e2e.ts	Adds DMPonline Playwright E2E gallery import scenario.
src/main/webapp/ui/src/modules/dmpassistant/tests/pageObjects/DMPAssistantImportDialogComponent.ts	Adds DMP Assistant import dialog Playwright helpers.
src/main/webapp/ui/src/modules/dmpassistant/tests/mock.ts	Adds MSW handlers + fixture wiring for DMP Assistant plan APIs.
src/main/webapp/ui/src/modules/dmpassistant/tests/fixtures/plans.json	Adds DMP Assistant plans fixture.
src/main/webapp/ui/src/modules/dmpassistant/tests/dmpassistant.e2e.ts	Adds DMP Assistant Playwright E2E gallery import scenario.
src/main/webapp/ui/src/modules/dcd/tests/mock.ts	Adds MSW handlers/constants for Digital Commons Data flow mocking.
src/main/webapp/ui/src/modules/dcd/tests/dcd.e2e.ts	Adds DCD Playwright E2E export/deposit scenario.
src/main/webapp/ui/src/modules/calira/tests/pageObjects/CaliraDialogComponent.ts	Adds Calira insert dialog Playwright helpers.
src/main/webapp/ui/src/modules/calira/tests/mock.ts	Adds MSW handlers/constants for Calira OAuth + API mocking.
src/main/webapp/ui/src/modules/calira/tests/calira.e2e.ts	Adds Calira Playwright E2E insert-booking scenario.
src/main/webapp/ui/src/modules/argos/tests/pageObjects/ArgosImportDialogComponent.ts	Adds Argos import dialog Playwright helpers.
src/main/webapp/ui/src/modules/argos/tests/mock.ts	Adds MSW handlers/constants for Argos API mocking.
src/main/webapp/ui/src/modules/argos/tests/argos.e2e.ts	Adds Argos Playwright E2E gallery import scenario.
src/main/webapp/ui/src/tests/e2e/pageObjects/workspace/WorkspacePage.ts	Wires Evernote import dialog into Workspace page object.
src/main/webapp/ui/src/tests/e2e/pageObjects/system/SystemConfigPage.ts	Adds helper to set multiple system settings in tests.
src/main/webapp/ui/src/tests/e2e/pageObjects/groups/GroupViewPage.ts	Adds group view page object used by RAiD E2E scenario.
src/main/webapp/ui/src/tests/e2e/pageObjects/gallery/GalleryPage.ts	Adds gallery “create/import” flows for multiple DMP providers and Argos.
src/main/webapp/ui/src/tests/e2e/pageObjects/document/DocumentEditorPage.ts	Wires multiple integration dialogs into the document editor page object.
src/main/webapp/ui/src/tests/e2e/pageObjects/apps/AppsPage.ts	Adds helper flows for enabling apps via OAuth/webhook and RAiD multi-server.
src/main/webapp/ui/src/tests/e2e/mockServer.ts	Registers new MSW handlers in the E2E mock server.
src/main/webapp/ui/src/tests/e2e/fixtures/ui.ts	Exposes new page objects/components as Playwright fixtures.
src/main/webapp/ui/src/tests/e2e/fixtures/dynamicUser.ts	Exports helper types/functions and returns context for teardown use.
src/main/webapp/ui/src/tests/e2e/env.ts	Adds env keys for Calira + Nextcloud real-mode credentials.
src/main/webapp/ui/src/tests/e2e/components/shared/ExportWizardComponent.ts	Adds wizard helpers for Report-to-RAiD and repository metadata inputs.
src/main/webapp/ui/src/tests/e2e/components/groups/GroupRaidConnectionsComponent.ts	Adds RAiD connections UI component helper for group view.
src/main/webapp/ui/src/tests/e2e/api/models/sysadmin.ts	Extends sysadmin group create request type to include PROJECT_GROUP.
src/main/webapp/ui/src/tests/e2e/api/clients/SysadminClient.ts	Adds mutation guard before creating sysadmin groups.
src/main/webapp/ui/.env.example	Adds Calira/Nextcloud env vars for E2E real-mode configuration.
src/main/java/com/researchspace/webapp/integrations/argos/ArgosDMPProvider.java	Uses a shared ObjectMapper with Jdk8Module for Optional DOI serialization.
src/main/java/com/researchspace/service/impl/AsyncDepositorImpl.java	Adjusts archive submission metadata handling around otherProperties.
docker/dev/entrypoint-app.sh	Adds JVM integration config for expanded E2E mock coverage.
docker/dev/docker-compose.yml	Provides RSPACE_BASE_URL for the E2E mock server redirect behavior.
.github/workflows/e2e.yml	Wires new mock/real integration args and secrets into CI E2E workflow.

Suppressed comments (2)

src/main/webapp/ui/src/modules/owncloud/tests/mock.ts:69

Same wildcard path issue here: "/owncloud/remote.php/webdav*" is unlikely to match the actual WebDAV endpoint paths, so the mock will not intercept PROPFIND/GET calls.
src/main/webapp/ui/src/modules/nextcloud/tests/mock.ts:69
Same issue as above: the handler path includes a literal * and is unlikely to intercept WebDAV calls. Use a RegExp (or a path-to-regexp parameter) to match the full WebDAV subtree.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

nebay-abraha · 2026-08-08T17:33:48Z

+  // Skipped: connect/connected.jsp double-escapes data-response (c:out around
+  // an already-escaped EL expression), which corrupts Slack's JSON OAuth
+  // payload and breaks the frontend's JSON.parse.
+  test.skip("As a user, I can connect a Slack channel via OAuth", async ({ componentToasts, componentSlackDialog }) => {


fix reverted, and test skipped

nebay-abraha · 2026-08-08T17:32:29Z

+  http.options(
+    "/owncloud/remote.php/webdav*",


MSW converts the trailing * to (.*), so this correctly matches /webdav/... paths.

+    String json = OBJECT_MAPPER.writeValueAsString(dmpDetails);
    InputStream is = new ByteArrayInputStream(json.getBytes());
    EcatDocumentFile file =


Adds RSPACE_BASE_URL for mock cross-origin redirects, CALIRA/NEXTCLOUD creds, and shared page objects/fixtures/env helpers used by the new per-app e2e mock+real test suites.

…app mocks and wevdav hardening

tchoi-rs

All good, some small issues:

tchoi-rs · 2026-08-12T15:58:58Z

+    componentNotifications,
+    componentToasts,
+  }) => {
+    await page.route("https://api.crossref.org/funders**", (route) =>


If it's possible to test for the exact ID, it should test for that

tchoi-rs · 2026-08-14T09:33:43Z

+    const radio = this.popup.getByRole("radio").first();
+    const row = this.popup.getByRole("listitem").filter({ has: radio }).first();
+    const fullText = await row.innerText();
+    const name = fullText.split(/\r?\nUpdated\b/)[0].trim();


Is this regex necessary?

tchoi-rs · 2026-08-14T09:41:01Z

+    const popup = await docEditor.openDropboxPicker();
+    await popup.waitForLoadState();
+
+    // const flow = new DropboxPickerFlow(popup);


Is this still needed?

tchoi-rs · 2026-08-14T09:46:42Z

+  ),
+
+  http.options(
+    "/nextcloud/remote.php/webdav*",


If possible, match for exact call paths

tchoi-rs · 2026-08-14T09:47:06Z

+    const popup = await docEditor.openOneDrivePicker();
+    await popup.waitForLoadState();
+
+    // const flow = new OneDrivePickerFlow(popup);


Is this needed?

tchoi-rs · 2026-08-14T09:51:29Z

+    await pageApps.setEnabled("Slack", true);
+  });
+
+  // Skipped: connect/connected.jsp double-escapes data-response (c:out around


Is this comment still correct?

tchoi-rs · 2026-08-14T09:52:36Z

+  });
+
+  test("As a user, I can import a protocol into a document field", async ({ page, pageWorkspace }) => {
+    await page.route(/^https:\/\/www\.protocols\.io\/api\/v3\/protocols\?/, (route) =>


This should not need regex

tchoi-rs · 2026-08-14T09:52:40Z

+    await page.route(/^https:\/\/www\.protocols\.io\/api\/v3\/protocols\?/, (route) =>
+      route.fulfill({ json: MOCK_PROTOCOLS_IO_SEARCH_RESPONSE }),
+    );
+    await page.route(/^https:\/\/www\.protocols\.io\/api\/v3\/protocols\/\d+$/, (route) =>


This should not need regex

tchoi-rs · 2026-08-14T09:55:07Z

+  ),
+
+  http.options(
+    "/owncloud/remote.php/webdav*",


Prefer exact URLs

tchoi-rs · 2026-08-14T09:55:09Z

+        },
+      }),
+  ),
+  http.all("/owncloud/remote.php/webdav*", ({ request }) => {


Prefer exact URLs

nebay-abraha requested a review from tchoi-rs as a code owner August 7, 2026 13:54

nebay-abraha marked this pull request as draft August 7, 2026 13:54

nebay-abraha force-pushed the integrations-apps branch from 4f0cbd5 to 272af9d Compare August 8, 2026 09:53

nebay-abraha requested a lite review from Copilot August 8, 2026 09:54

Copilot started reviewing on behalf of nebay-abraha August 8, 2026 09:54 View session

Copilot AI reviewed Aug 8, 2026

View reviewed changes

nebay-abraha marked this pull request as ready for review August 8, 2026 10:09

nebay-abraha marked this pull request as draft August 9, 2026 14:21

nebay-abraha marked this pull request as ready for review August 10, 2026 07:01

nebay-abraha added 20 commits August 10, 2026 19:23

feat(e2e) add slack mock test coverage

a4b7178

test(e2e) shared infra for per-app integration coverage

aa10939

Adds RSPACE_BASE_URL for mock cross-origin redirects, CALIRA/NEXTCLOUD creds, and shared page objects/fixtures/env helpers used by the new per-app e2e mock+real test suites.

test(e2e) add argos mock+real coverage

3a1313f

test(e2e) add calira mock+real coverage

75c85eb

test(e2e) add dcd mock+real coverage

fce43ea

test(e2e) add dmpassistant mock+real coverage

e72bcda

test(e2e) add dmponline mock+real coverage

0b7d5f1

test(e2e) add dmptool mock+real coverage

5ebcee7

test(e2e) add dryad mock+real coverage

398352b

test(e2e) add evernote mock+real coverage

2d18c5c

test(e2e) add github mock+real coverage

7a83025

test(e2e) add msteams mock+real coverage

a8d7f1f

test(e2e) add nextcloud mock+real coverage

28b80e0

test(e2e) add orcid mock+real coverage

4efb819

test(e2e) add owncloud mock+real coverage

c78ebcc

test(e2e) add protocolsio mock+real coverage

aee465c

test(e2e) add raid mock+real coverage

f1705e2

fix(e2e)update raid record msg

761e4ec

fix: preserve deposit metadata properties during RAID/ICSN merge

66252e6

fix: quote dynamic class attribute in GitHub tree view

4245f7e

nebay-abraha added 13 commits August 10, 2026 19:24

fix: support Optional DOI serialization in Argos DMP export

019fa5c

skip slack mock test due to corruptd JSON OAuth

3c9f8d7

test(e2e) add chemistry and chemdraw coverage

11e4d96

test(e2e) add snapGene mock coverage, fix gallery selection race

f5fe6ad

test(e2e) add aspose check coverage via page.route

4545631

refactor(e2e): extract shared mockOauthAuthorize helper across OAuth …

4d8a896

…app mocks and wevdav hardening

refactor(e2e): update locators and extract shared mocks

df3f306

test(e2e) add video embed coverage

892e5ff

test(e2e) add box and dropbox coverage

f3bb3f2

test(e2e) add ms teams and oneDrive coverage

296dbee

test(e2e) add github mocked adversarial path

0c9f8e3

fix(e2e) resolve mockOAuthorize via relative path

e67daf4

update(e2e) owncloud test as cors issue is now fixed

a191c1f

nebay-abraha force-pushed the integrations-apps branch from b4dadfd to a191c1f Compare August 10, 2026 18:24

nebay-abraha added 4 commits August 11, 2026 09:19

fix(e2e) snapgene mock test

1703ae1

fix(e2e) re-auth password field

699c8b5

debug(e2e): playwright report is not uploaded to github artifacts

d15bca3

debug(e2e): remove debugging step

c6dd354

tchoi-rs requested changes Aug 14, 2026

View reviewed changes

nebay-abraha added 3 commits August 16, 2026 23:18

test(e2e) address pr review comment

628b587

merge 'origin/main' into integrations-apps

4cc7bd1

test(e2e) update broken tests

70fcefd

nebay-abraha requested a review from tchoi-rs August 18, 2026 06:02

Uh oh!

Conversation

nebay-abraha commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

minor fixes

Testing notes

Uh oh!

github-actions Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats — Frontend bundle size change

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tchoi-rs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nebay-abraha commented Aug 7, 2026 •

edited

Loading

github-actions Bot commented Aug 7, 2026 •

edited

Loading