Use __send__ instead of send #3045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Jul 27, 2023
richardplatel
force-pushed
the
safer-method-send
branch
from
d3d6aec
to
3495630
Compare
pirj
reviewed
Jul 27, 2023
| @@ -9,6 +9,11 @@ module RSpec::Core | |||
| expect(output.string).to eq("message\nanother message").and eq(wrapper.string) | |||
| end | |||
|
|
|||
| it 'proxies IO instance methods with __send__ to be compatiable with IOs that redefine send' do | |||
| expect(output).to receive(:__send__).with(:puts, 'message') | |||
There was a problem hiding this comment.
Please accept my apologies for not making myself clear.
Would it be possible to add a real-world case here that would fail with send but would work with __send__? TCPSocket or others?
There was a problem hiding this comment.
Thanks for looking at my PR @pirj!
How about this test?
richardplatel
force-pushed
the
safer-method-send
branch
3 times, most recently
from
e4e4591
to
31220b3
Compare
richardplatel
force-pushed
the
safer-method-send
branch
from
31220b3
to
9fc8f5a
Compare
|
@pirj Could use some help here figuring out how to write this test. Seems like making a real TCPSocket is not ideal but I'm not sure how to mock it in a way that still tests the change. Or maybe there another approach? |
|
Thanks for spotting this, I've merged your commit with an updated spec. (0ff6358) |
|
This has been released in 3.12.3, sorry about the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSpec::Core::OutputWrapper uses
sendto call class methods onIOobjects, but someIOobjects (e.g.TCPSocket) redefinesend. Use the equivalent__send__method instead.https://apidock.com/ruby/BasicObject/__send__