Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproduction script that use gems from repos/ #221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benoittgt
Copy link
Member

Hello

I always look at the best way to start contributing to RSpec. I think rspec-dev is full of powerfull rake commands but lack of documentation to properly start hacking RSpec.

The idea here is to have a basic test suite that will use gems from repos/.

If you love the idea I think we can add some doc to contributing guide with for example.

  1. git clone https://github.com/rspec/rspec-dev
  2. cd rspec-dev && bundle install
  3. rake git:clone
  4. cd repro-scripts && bundle install
  5. bundle exec rspec

Or add a rake task that handle this.

@JonRowe
Copy link
Member

JonRowe commented Aug 1, 2019

I'd rather we generate an issue template that has a reproduction script, it should be the inline style rather than a cloneable repo etc.

@benoittgt
Copy link
Member Author

Mmmmh that's a very good idea. I will make this.

@benoittgt benoittgt self-assigned this Aug 19, 2019
@benoittgt
Copy link
Member Author

Is it still something that should be done? @pirj would you use this?

@pirj
Copy link
Member

pirj commented Dec 22, 2019

As from my rather limited experience, it's not too hard to address issues in RSpec, but I've only scratched the surface and haven't faced anything that would need several repositories to reproduce the issue yet.

It would be helpful though to extend CI build scripts to include all repos' builds since there might be failures caused by other repos, e.g. I almost accidentally rspec-its by a change in rspec-expectations, and I wouldn't notice it if I wouldn't run a test suite using its with my latest changes to rspec-expectations. Not sure if it's a frequent problem though.
PS Nevermind, we already do this, just not to secondary league, i.e. rspec-collection-matchers and rspec-its.

@JonRowe
Copy link
Member

JonRowe commented Dec 22, 2019

What I'm envisioning is an inline bundle specifying master versions of our gems by default, and an example spec, there is one floating around in a gist somewhere I think, but the idea is to make it easy for someone to create a standalone one file reproduction of an issue.

@JonRowe JonRowe changed the base branch from master to main August 1, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants