This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Define module we can use to safely rescue most exceptions. #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone want to review this? It supports rspec/rspec-expectations#844 and rspec/rspec-core#2063. |
|
I'd love to get this merged before leaving on my 3-week vacation tomorrow. Anyone want to review this, @rspec/rspec ? Bear in mind that the failures from the rspec-core and rspec-expectations PRs are due to a bug in our build scripts -- see rspec/rspec-dev#137. |
|
looking... |
| # @private | ||
| module AllExceptionsExceptOnesWeMustNotRescue | ||
| # These exceptions are dangerous to rescue as rescuing them | ||
| # would interfere with things we should not interfere with. |
|
LGTM |
xaviershay
added a commit
that referenced
this pull request
Aug 31, 2015
Define module we can use to safely rescue most exceptions.
|
Thanks, @xaviershay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.