Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade marisa-trie for compatibility with Python 3.11+ #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

e-pavlica
Copy link

@e-pavlica e-pavlica commented Feb 12, 2024

  • Bump version to 2.0 as this change ends support for Python 3.6
  • prevent deprecation warnings from pkg_resources.resource_filename usage

@georgkrause
Copy link

I picked up the pkg_resources replacement in my repository. Sadly the patch destroys compatibility with python 3.8, which is why I added some magic to make it work on 3.8. This is going to be included in the next version released to pypi soon. Thank you @e-pavlica for the initial work done!

@georgkrause
Copy link

FYI the changes in 877fb4f are incompatible with python 3.8, which is why I will only deploy them as soon as 3.8 is EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants