Add how to install guide #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why CPM does not want to include the modules, but this needs to be resolved asap.
No need to pollute the console with too many messages.
Didn't know about PROJECT_IS_TOP_LEVEL
This part simply will not work, when any kind of package installation is wrapped inside a cmake function, due to cmake's variable scope. It is pure luck that our `FetchContent_Declare` example works.
For now, this acts as a test to see how both cmake's FetchContent module and CPM treats it.
For now, this is a test of the configuration mechanism, to see how cmake's FetchContent module and CPM treats it.
This is needed or the GNUInstallDirs module isn't going to work as intended.
This reverts commit 6e0a0ef. Had no effect on the config file's state of being read by the consuming client project. Thus, the GNUInstallDirs are not needed!
Not sure if this is going to work without the "targets" part, but example code looks more promising that previous.
Not sure about this, but seems that both CPM and find_package() uses this path to search for the configuration files first.
This failed, and there seems to be no good way around it. Consuming packages MUST manually append to their CMAKE_MODULE_PATH.
kernelguy
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds installation guide.
Note
During local / manual installation tests, a sever issue was discovered. When installing this package via CPM, the
rsp/*modules were not made available. For now, the guide entails how clients can manually append our modules, to make them work, when installing via CPM.References
See cpm-cmake/CPM.cmake#532 for additional details.