Skip to content

maint: remove extra / in doctest #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

maint: remove extra / in doctest #330

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af8cb99
remove extra /
isabelizimm Apr 29, 2025
62a069d
use Path instead of strs for path construction
isabelizimm Apr 30, 2025
c6a0dd0
update docstring to url
isabelizimm Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pins/boards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ def pin_meta(self, name, version: str = None) -> Meta:
# ensure pin and version exist
if not self.fs.exists(self.construct_path([pin_name, version])):
raise PinsError(
f"Pin {name} either does not exist, "
f"or is missing version: {version}."
f"Pin {name} either does not exist, or is missing version: {version}."
)

selected_version = guess_version(version)
Expand Down Expand Up @@ -881,9 +880,10 @@ class BoardManual(BaseBoard):
--------
>>> import fsspec
>>> import os
>>> fs = fsspec.filesystem("github", org = "rstudio", repo = "pins-python")
>>> fs = fsspec.filesystem("http", block_size=0)
>>> pin_paths = {"df_csv": "df_csv/20220214T163720Z-9bfad/"}
>>> board = BoardManual("pins/tests/pins-compat", fs, pin_paths=pin_paths)
>>> url = "https://raw.githubusercontent.com/rstudio/pins-python/main/pins/tests/pins-compat"
>>> board = BoardManual(url, fs, pin_paths=pin_paths)

>>> board.pin_list()
['df_csv']
Expand Down Expand Up @@ -984,7 +984,6 @@ def construct_path(self, elements):
return "/".join(pre_components + [pin_path])
elif len(others) == 2:
version, meta = others

return "/".join(pre_components + [stripped, meta])

raise NotImplementedError(
Expand Down
Loading