per-package interactive recovery in restore()#2216
Closed
kevinushey wants to merge 6 commits intomainfrom
Closed
Conversation
When a package fails during an interactive restore (prompt = TRUE), the user is now prompted with a menu to install the latest version, skip the package, or cancel the restore. This is useful after R upgrades when old package versions may no longer compile. The handler selection follows three modes: - prompt = TRUE: per-package interactive recovery menu - continue = TRUE: accumulate errors, report at end - neither: error propagates immediately (existing default) Closes #1893
The interactive recovery menu now includes a fourth choice allowing the user to enter a version number (e.g. "1.2.0") or an arbitrary remote (e.g. "user/repo") to install when a package fails to restore.
Collaborator
Author
|
This PR won't be compatible with the new parallel installation code; we'll need to rework this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
restore()(prompt = TRUE), the user is now prompted with a menu offering three choices: install the latest version, skip the package, or cancel the restore.continueparameter torestore()for non-interactive error accumulation (reports all failures at the end).prompt = TRUE→ interactive recovery menu;continue = TRUE→ accumulate errors; neither → immediate error (existing default).Closes #1893
Test plan
renv.menu.choice = 2Lrenv.menu.choice = 1Lrenv.menu.choice = 3Lrenv::restore()interactively after upgrading R with a lockfile containing an old package version