Merged
Conversation
nealrichardson
force-pushed
the
migrate-v1-apis
branch
from
33ac8ab to
ccebe11
Compare
nealrichardson
commented
Jan 21, 2026
| resetMaxRecords = true | ||
| } | ||
|
|
||
| let n = 0 |
Contributor
Author
There was a problem hiding this comment.
v1/content is not paginated, that's the reason for this diff
marcosnav
approved these changes
Jan 28, 2026
marcosnav
left a comment
marcosnav
left a comment
There was a problem hiding this comment.
Looks good! one minor cleanup suggestion/question
src/Deployer.ts
Outdated
| import { Bundle } from './Bundle' | ||
| import { Bundler } from './Bundler' | ||
| import { Application, ClientTaskV0Response, ListApplicationsResponse } from './api-types' | ||
| import { Application, DeployV1Response, ListApplicationsResponse } from './api-types' |
There was a problem hiding this comment.
I think ClientTaskV0Response can be removed from the codebase now?
tdstein
approved these changes
Jan 28, 2026
Replace undocumented/legacy application endpoints with stable v1 content APIs:
- createApp: POST applications → POST v1/content
- getApp: GET applications/${id} → GET v1/content/${guid}
- updateApp: POST applications/${id} → PATCH v1/content/${guid}
- uploadApp: POST applications/${id}/upload → POST v1/content/${guid}/bundles
- deployApp: POST applications/${id}/deploy → POST v1/content/${guid}/deploy
- listApplications: GET applications → GET v1/content (with v1 pagination)
- getBundle: GET bundles/${id} → GET v1/content/${guid}/bundles/${id}
Updates Deployer to pass GUIDs instead of numeric IDs, and ListApplicationsPager
to use page-based pagination (pageNumber/pageSize) instead of offset-based.
Closes #43
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- v1/content endpoint is not paginated, removed fake pagination params - v1 deploy endpoint returns task_id (not id), added DeployV1Response type - Simplified ListApplicationsPager to fetch all results at once Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename Application interface to Content with only fields actually used - Add include=vanity_url query param to GET endpoints - Update field types to match v1 API (id, bundleId as strings) - Rename ListApplicationsPager to ListContentPager - Rename APIClient methods to use Content terminology - Update tests to match new names Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nealrichardson
force-pushed
the
migrate-v1-apis
branch
from
ccebe11 to
cff068b
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The `include=vanity_url` query param isn't supported on older Connect
versions. Instead, use GET /v1/content/{guid}/vanity to check if a
vanity URL exists before setting one.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43