chore: update dependencies and Node.js to latest LTS#49
Merged
nealrichardson merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
- Update CI matrix from Node 18/20 to Node 20/22 - Update TypeScript from 4.9 to 5.8 - Update @tsconfig/node16 to @tsconfig/node22 - Update @types/node from 14.x to 22.x - Update tar from 6.x to 7.x (includes built-in types) - Update tough-cookie from 4.x to 5.x - Update ts-standard from 9.x to 12.x - Update ts-node from 9.x to 10.x - Update various other dependencies to latest versions - Add isolatedModules: true to tsconfig for Node22 module compatibility - Fix tar import for v7 API changes - Fix type re-exports for isolatedModules - Apply linter auto-fixes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
marcosnav
approved these changes
Jan 29, 2026
marcosnav
left a comment
marcosnav
left a comment
There was a problem hiding this comment.
Approving. Although found surprising that this repo has a mix of Promise practices, try/catch and async/await used interchangeably, something that makes asynchronous flow hard to follow and causes inconsistent error handling.
Claude should be able to fix that pretty easily.
| } | ||
|
|
||
| return this.findExistingContentByName(name) | ||
| return await this.findExistingContentByName(name) |
There was a problem hiding this comment.
This await here caught my attention, there is an odd mix of async/await and then/catch in this method. Not specific to this PR, since seem to be a past practice in many places in this repo.
There was a problem hiding this comment.
Created a separate issue for this #50. I'll delegate this to Claude later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code