fix: preserve gh run view passthrough args#419
Open
tsubasakong wants to merge 3 commits intortk-ai:masterfrom
Open
fix: preserve gh run view passthrough args#419tsubasakong wants to merge 3 commits intortk-ai:masterfrom
tsubasakong wants to merge 3 commits intortk-ai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk gh run viewstraight through before trying to extract a positional run ID when the user requested raw log/JSON outputrtk gh run view --log-failed --job <job-id>instead of misclassifying the job id as the run id--job/--attemptconsume values, and add focused regression tests for those casesFixes #416.
Validation
git diff --checkcargo) is not installed on this host, so unit tests could not be executed locally in this opener lane