fix: npm routing, discover cat redirect, proxy quoted args#480
Open
pszymkowiak wants to merge 1 commit intodevelopfrom
Open
fix: npm routing, discover cat redirect, proxy quoted args#480pszymkowiak wants to merge 1 commit intodevelopfrom
pszymkowiak wants to merge 1 commit intodevelopfrom
Conversation
#388) #470: rtk npm now correctly routes npm subcommands (install, list, audit, etc.) without injecting "run". Previously, `rtk npm install` was executed as `npm run install`. #315: discover no longer counts `cat >`, `cat >>`, `cat |` as missed savings. These are write/pipe operations with no terminal output to compress. #388: rtk proxy now auto-splits a single quoted argument containing spaces. `rtk proxy 'head -50 file.php'` now works like `rtk proxy head -50 file.php`. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
pszymkowiak
force-pushed
the
fix/batch-bugs-470-289-315
branch
from
ae631da to
46dded7
Compare
pszymkowiak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #470, Closes #315, Closes #388
Summary
#470 — npm run is broken
rtk npm installwas executingnpm run installinstead ofnpm installruninjected#315 — discover: cat > inflates savings
cat > file.txt,cat >> file.txt,cat | grepare write/pipe operations with no terminal outputclassify_command()to exclude redirects#388 — rtk proxy fails with quoted command (P2)
rtk proxy 'head -50 file.php'(one quoted arg) instead of separate argsTest plan
cargo test— 770 passedrtk npm run build→ works ✅rtk npm install→ no longer runsnpm run install✅rtk proxy 'head -5 Cargo.toml'→ works ✅cat > fileclassified as Unsupported ✅