Add super advice for hooks
#35
Conversation
README.adoc
Outdated
| end | ||
| ---- | ||
|
|
||
| # good |
There was a problem hiding this comment.
I think you forgot to delete this.
README.adoc
Outdated
| def setup | ||
| stub_something | ||
| end | ||
| end |
There was a problem hiding this comment.
The bad case and the good case are the same. For POROs that are not inherited from Minitest::Test, it may be clearer to remove them from the example code.
|
|
||
| def setup | ||
| do_something | ||
| super |
There was a problem hiding this comment.
IMO, as the example code, it may be better to set up the superclass first.
def setup
super
do_something
endThere was a problem hiding this comment.
Updated. I've also added a teardown example as I believe that would typically be in the opposite order.
| @@ -480,6 +480,47 @@ _ { raise_exception }.must_raise TypeError | |||
|
|
|||
| Check the http://docs.seattlerb.org/minitest/Minitest/Expectations.html[Minitest::Expectations doc] for more information about its usage. | |||
|
|
|||
| === Hooks [[hooks]] | |||
There was a problem hiding this comment.
It may be even clearer :-)
| === Hooks [[hooks]] | |
| === Lifecycle Hooks [[lifecycle-hooks]] |
There was a problem hiding this comment.
I considered that, but the Minitest docs seem to indicate that 'lifecycle hooks' are things such as before_setup and after_teardown, which are "meant for library writers, NOT for regular test authors."
https://www.rubydoc.info/gems/minitest/5.9.1/Minitest/Test/LifecycleHooks
There was a problem hiding this comment.
I get it. Thank you for the explanation!
andyw8
force-pushed
the
andyw8/add-hooks-super-note
branch
from
a6cd680
to
535301b
Compare
andyw8
force-pushed
the
andyw8/add-hooks-super-note
branch
from
535301b
to
b348034
Compare
|
Thank you! |
As suggested by @koic in rubocop/rubocop-minitest#111