Skip to content

[Fix #1083] Add new Rails/BeforeDestroy cop #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ydakuka
Copy link
Contributor

@ydakuka ydakuka commented Feb 19, 2025

Fixes #1083
Based on #245

Other implementations: #220 , #922


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote [good commit messages].
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@ydakuka ydakuka changed the title Add new Rails/BeforeDestroy cop [Fix #1083] Add new Rails/BeforeDestroy cop Feb 19, 2025
@ydakuka ydakuka force-pushed the 1083-before-destroy-callback-before-dependent-destroy-associations branch from d4bba8d to 4f59092 Compare February 19, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cop idea: Ensure the correct usage of prepend: true in before_destroy callbacks.
1 participant