[Fix #1435] Add a new cop for PluckOnSelect. #1468
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select returns an ActiveRecord relation with only the selected column(s) marked for retrieval. Pluck returns an array of column values. Using them together is at best redundant and at worst confusing and inefficient. When chained with
.select
,.pluck
is unaware of any RAW SQL directive passed to .select (e.g. column aliases or a DISTINCT clause). This can lead to unexpected behavior.The aggressive style of this cop asserts that there is always a better alternative than using pluck and select together. A conservative style is offered for people who prefer to ignore this cop for selects with block arguments.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.