Skip to content

[Fix #1435] Add a new cop for PluckOnSelect. #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blnoonan
Copy link

Select returns an ActiveRecord relation with only the selected column(s) marked for retrieval. Pluck returns an array of column values. Using them together is at best redundant and at worst confusing and inefficient. When chained with .select, .pluck is unaware of any RAW SQL directive passed to .select (e.g. column aliases or a DISTINCT clause). This can lead to unexpected behavior.

The aggressive style of this cop asserts that there is always a better alternative than using pluck and select together. A conservative style is offered for people who prefer to ignore this cop for selects with block arguments.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant