Update allowlist of methods to ignore for false positives #900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created as a draft for now so I can come back and add some examples to reproduce the issue I'm having and give some more context.
Back in September of last year @pyromaniac reported an issue with false positives for the Rails/HttpPositionalArguments cop when routes are defined within specs. That issue was subsequently fixed by #533. However there was one piece that was not fully addressed.
While the following code will no longer produce a false positive:
We'll still get a false positive when the `append` method is invoked
Adding to the list of methods to ignore for false positives seems to successfully address this issue. The change is very small.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.