Skip to content

Shared parameters are not inherited #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Shared parameters are not inherited #2114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions spec/grape/api/shared_helpers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@
end
end

nested = Class.new(Grape::API) do
params do
use :pagination
end
get '/child' do
declared(params, include_missing: true)
end
end

Class.new(Grape::API) do
helpers shared_params
format :json
Expand All @@ -23,6 +32,8 @@
get do
declared(params, include_missing: true)
end

mount nested
end
end

Expand All @@ -35,4 +46,10 @@ def app
expect(last_response.status).to eq 200
expect(last_response.body).to eq({ page: nil, size: nil }.to_json)
end

it 'inherits parameters' do
get '/child'
expect(last_response.status).to eq 200
expect(last_response.body).to eq({ page: nil, size: nil }.to_json)
end
end